Skip to content

Remove old roborock map storage#157379

Merged
balloob merged 1 commit intohome-assistant:devfrom
allenporter:roborock-file-fix
Nov 27, 2025
Merged

Remove old roborock map storage#157379
balloob merged 1 commit intohome-assistant:devfrom
allenporter:roborock-file-fix

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented Nov 26, 2025

Proposed change

Remove old roborock map storage. The old map directory and new config json path share a name which is hurting startup. This now removes the old path when its a directory so we can write the new config to this.

This was identified in #154837 as a post PR cleanup improvement, but turned out to break startup when existing configuration exists.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@allenporter allenporter added this to the 2025.12.0b0 milestone Nov 26, 2025
@allenporter allenporter requested review from edenhaus and removed request for Copilot November 26, 2025 20:51
@allenporter
Copy link
Copy Markdown
Contributor Author

Tagging for b0, but really should be b1

@balloob balloob modified the milestones: 2025.12.0b0, 2025.12.0 Nov 27, 2025
@balloob balloob merged commit 42cbeca into home-assistant:dev Nov 27, 2025
41 of 42 checks passed
frenck pushed a commit that referenced this pull request Nov 27, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock not setting up in 2025.12.0b0

4 participants