Skip to content

Feature/intellifire double poll#162670

Closed
jeeftor wants to merge 5 commits intohome-assistant:devfrom
jeeftor:feature/intellifire_double_poll
Closed

Feature/intellifire double poll#162670
jeeftor wants to merge 5 commits intohome-assistant:devfrom
jeeftor:feature/intellifire_double_poll

Conversation

@jeeftor
Copy link
Copy Markdown
Contributor

@jeeftor jeeftor commented Feb 9, 2026

Proposed change

In the current mode of operation Home Assistant will issue a change request to the fireplace in the backing lib. The backing library will issue the change and then home assistant will wait until it polls the sate of the fireplace again to pick up the change. This leads to slower responsiveness.

In the backing library we implemented a pull request (jeeftor/intellifire4py#239) to add additional functionality allowing for faster change detection on the fireplace. Hence removing the double polling situation by adding a perform_poll command to the backing library allowing Home assistant to trigger a poll on command.

Backing Lib Changes

jeeftor/intellifire4py@v4.3.1...v4.4.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

  Allow users to configure whether the integration uses local or cloud
  endpoints for reading data and controlling the fireplace through an
  options flow in the UI.

  Features:
  - Options flow to select read mode (local/cloud) and control mode
  - Validates connectivity before accepting mode changes
  - Shows error if selected mode is unavailable
  - Only updates modes that actually changed (no unnecessary reloads)
  - Add read_mode and control_mode diagnostic sensors

  Bug fix:
  - Convert string options to IntelliFireApiMode enum in _construct_common_data
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions Bot added the stale label Apr 14, 2026
@github-actions github-actions Bot closed this Apr 22, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant