Feature/intellifire double poll#162670
Closed
jeeftor wants to merge 5 commits intohome-assistant:devfrom
Closed
Conversation
Allow users to configure whether the integration uses local or cloud endpoints for reading data and controlling the fireplace through an options flow in the UI. Features: - Options flow to select read mode (local/cloud) and control mode - Validates connectivity before accepting mode changes - Shows error if selected mode is unavailable - Only updates modes that actually changed (no unnecessary reloads) - Add read_mode and control_mode diagnostic sensors Bug fix: - Convert string options to IntelliFireApiMode enum in _construct_common_data
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In the current mode of operation Home Assistant will issue a change request to the fireplace in the backing lib. The backing library will issue the change and then home assistant will wait until it polls the sate of the fireplace again to pick up the change. This leads to slower responsiveness.
In the backing library we implemented a pull request (jeeftor/intellifire4py#239) to add additional functionality allowing for faster change detection on the fireplace. Hence removing the double polling situation by adding a
perform_pollcommand to the backing library allowing Home assistant to trigger a poll on command.Backing Lib Changes
jeeftor/intellifire4py@v4.3.1...v4.4.0
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: