Remove end_live_activity command#4616
Open
rwarner wants to merge 2 commits intohome-assistant:mainfrom
Open
Conversation
clear_notification with a tag already ends Live Activities via HandlerClearNotification, making end_live_activity redundant. Removes HandlerEndLiveActivity and its registration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the dedicated end_live_activity notification command from the iOS app, relying on the existing clear_notification + tag path to end Live Activities (aligning iOS behavior with Android).
Changes:
- Unregisters the
"end_live_activity"command fromNotificationCommandManager. - Deletes
HandlerEndLiveActivityimplementation from the Live Activity command handler file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift | Removes registration for the deprecated end_live_activity command. |
| Sources/Shared/Notifications/NotificationCommands/HandlerLiveActivity.swift | Removes the now-unused HandlerEndLiveActivity command handler type. |
Drops HandlerEndLiveActivityTests and all end_live_activity routing tests. clear_notification with a tag covers the dismissal path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bgoncal
approved these changes
May 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4616 +/- ##
=======================================
Coverage ? 43.77%
=======================================
Files ? 278
Lines ? 16915
Branches ? 0
=======================================
Hits ? 7405
Misses ? 9510
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HandlerEndLiveActivityand its registration inNotificationCommandManagerclear_notificationwith atagalready ends Live Activities viaHandlerClearNotification— no separate command neededclear_notificationexclusivelyCompanion docs PR: home-assistant/companion.home-assistant#1303
Test plan
live_update: truenotification to start a Live Activityclear_notificationwith the sametag— activity ends correctly🤖 Generated with Claude Code