Inherit os.Stdin directly from the parent process#416
Open
myaaaaaaaaa wants to merge 1 commit intohomeport:mainfrom
Open
Inherit os.Stdin directly from the parent process#416myaaaaaaaaa wants to merge 1 commit intohomeport:mainfrom
myaaaaaaaaa wants to merge 1 commit intohomeport:mainfrom
Conversation
Author
|
It's worth noting that the original version didn't even work in the first place - since both the child process and # Want
$ echo hi | sleep 0
# Got (before this PR is applied)
$ echo hi | termshot sleep 0
hi
# Got (after this PR is applied)
$ echo hi | termshot sleep 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
termshot command </dev/null(common in non-interactive environments such as CI) can result in the output ofcommandbeing truncated.This bug is due to a race condition where the instant EOF of
/dev/nullcan causedefer func() { _ = pt.Close() }()to run before the output ofcommandis finished writing. Sincestdin,stdout, andstderrall refer to the same pty, this also closesstdout, which results in the rest ofcommand's output being discarded.Partially fixes #412