Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch rounds down the floating point glyph sizes into whole numbers, so that cells are always lined up to pixels. The results aren't perfect, but at least any rendering issues should show up consistently now.
The first commit adds just the reproducer, and the second one fixes it. Here is a link to the diff, search for
expected-cells.pngif it doesn't automatically scroll down for you:ecf7539#diff-66b015e1bda893fe3715ab4244cd4dc0ccca5b9f6256b8310b2c17bbd3185b00
Before
After