Open
Conversation
RSCW-Duisburg
commented
Oct 10, 2024
RSCW-Duisburg
commented
| Q | A |
|---|---|
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | no |
| Deprecations? | yes/no |
| Tests pass? | yes/no |
| Fixed tickets | #... |
saitho
suggested changes
Oct 21, 2024
Contributor
saitho
left a comment
saitho
left a comment
There was a problem hiding this comment.
Just roughly reviewed the changes without testing them.
| { | ||
| // Get the Fluid namespaces from the global configuration | ||
| $namespaces = $GLOBALS['TYPO3_CONF_VARS']['SYS']['fluid']['namespaces'] ?? []; | ||
| $resolver = (new Typo3Version())->getMajorVersion() > 11 |
Contributor
There was a problem hiding this comment.
Dadurch geht mindestens die Kompatibilität mit TYPO3 11 verloren, welche laut Dependencies noch gewährleistet wird.
| $view->getRenderingContext()->getTemplatePaths()->setTemplateSource($template); | ||
|
|
||
| // Set the ViewHelperResolver from TYPO3Fluid | ||
| $resolver = new ViewHelperResolver(); |
Contributor
There was a problem hiding this comment.
Können wir die Instanz via GeneralUtility::makeInstance initialisieren? Ebenfalls oben bei TemplateVIew
| "typo3/cms-fluid": "^11.5 || ^12.4", | ||
| "typo3/cms-fluid-styled-content": "^11.5 || ^12.4", | ||
| "typo3/cms-frontend": "^11.5 || ^12.4" | ||
| "typo3/cms-backend": "^11.5 || ^12.4 || ^13", |
Contributor
There was a problem hiding this comment.
Dependencies zu prüfen – je nach Änderungen ((Nicht)Verwendung ObjectManager o. RequireJS?) könnte Support für ältere Versionen wegfallen.
|
@saitho @RSCW-Duisburg Is any of you doing active work on updating this PR? |
Contributor
|
Nope :) |
Author
|
not planed |
|
@hoogi91 Anything on your schedule to merge and release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.