Refactor commands#290
Open
hopskipnfall wants to merge 8 commits intomasterfrom
Open
Conversation
- Add /permaban and /permamute commands to automatically persist to access.cfg - Add /info command to view active restrictions and internal reasons - Expand /clear to accept User IDs and Names - Support optional hidden reasons for bans and mutes - Add persistent tracking for rule issuers and reasons
- Add AccessManager2Test.kt with 33 unit tests covering: - TempBan and Silence issuer/reason tracking and expiry - addTempBan, addSilenced, getTempBan, getSilence - addPermaBan and addPermaMute: runtime enforcement + access.cfg writes - clearTemp, isAddressAllowed, isSilenced, getAccess - Fix bug in AccessManager2.loadAccess: silence lines (format 'silence,<ip>') only have 2 tokens but the parser required at least 3, causing permanent mutes to be silently skipped on reload - Update FakeAccessManager in GameChatE2ETest and GameDataE2ETest to implement the new AccessManager interface methods
Documents all EmuLinker-K-specific admin commands and access.cfg extensions introduced in this branch: - /permaban, /permamute: persistent bans/mutes written to access.cfg - /info: view active restrictions and internal reasons - /clear: now accepts UserID or name in addition to IP - Optional reason parameter on /ban and /silence (internal only) - New 'silence,<ip>' entry type in access.cfg
PingBenchmark, LoginBenchmark, and GameDataBenchmark all had FakeAccessManager implementations that hadn't been updated to implement the new AccessManager interface methods, causing jmh compilation to fail.
hopskipnfall
force-pushed
the
feature/command-system-refactor
branch
from
69f21e0 to
b1c7591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.