fix/remove deprecated listheaders dependency#15
Merged
TDannhauer merged 3 commits intoFRAMEWORK_6_0from Apr 9, 2026
Merged
Conversation
This class contained methods marked as deprecated since 2014 and used in only 3 places all over the code base. The UPGRADING guide had instructions to migrate off them but some last callers remained. These callers have since been patched. This commit deletes both the actual "Deprecated" class and the fallback code which called into it. Michael intended the Mime_Headers class to be lightweight and low level, having higher level API in separate classes. The Deprecated class was also the only reason why Mime had a hard dependency on ListHeaders. ListHeaders in turn had a much more reasonable dependency on Mime. This circular dependency created some problems with composer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class contained methods marked as deprecated since 2014 and used in only 3 places all over the code base.
The UPGRADING guide had instructions to migrate off them but some last callers remained.
These callers have since been patched.
This commit deletes both the actual "Deprecated" class and the fallback code which called into it.
Michael intended the Mime_Headers class to be lightweight and low level, having higher level API in separate classes.
The Deprecated class was also the only reason why Mime had a hard dependency on ListHeaders.
ListHeaders in turn had a much more reasonable dependency on Mime.
This circular dependency created some problems with composer.