Big Sur support and compiling with Xcode 12.5.1#668
Open
vsaase wants to merge 8 commits intohorosproject:horosfrom
Open
Big Sur support and compiling with Xcode 12.5.1#668vsaase wants to merge 8 commits intohorosproject:horosfrom
vsaase wants to merge 8 commits intohorosproject:horosfrom
Conversation
Contributor
|
Thank you very much @vsaase - this compiles and runs for me on 11.5.1. As far as I'm aware this is the only PR submitted that has allowed Horos to compile on MacOS 10.15/11.x with the relevant Xcode versions. I hope the maintainers are able to have a look at this in the very near future, as it has the potential to get us over one of the hurdles that has held up Horos development. It would be good to see development proceeding again. If acceptable for merging, I wonder whether it would be ideal to split the PRs into separate fixes for compiling, toolbar fixes etc and credentials. (I have an old open PR (#581) for handling the signing credentials also.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
these changes allow to compile Horos with Xcode 12.5.1 and run it on Big Sur.
I changed the signing procedure to ad-hoc signing, as I obviously do not have access to your credentials.
I fixed the glitches with the Toolbar, unfortunately this leads to a bit of waste of screen space.
I updated GDCM to the current version to fix the runtime errors that resulted from different versions of CharLS used by Horos directly (2.0.0) and by GDCM (1.x previously).
Maybe someone could test this on Catalina? I only have access to Big Sur atm.