fix: error on malformed decimal type strings#75
Merged
Conversation
Change parse_decimal() to return an error when decimal types have more than 2 parameters (e.g., decimal(1,2,3)) instead of silently treating them as non-decimal types and falling through to "unknown type". Also adds test coverage for negative scales which are valid in Arrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_decimal()to returnErrwhen decimal types have more than 2 parameters (e.g.,decimal(1,2,3)) instead of silently returningOk(None)and falling through to the unknown type errordecimal(10, -2)) which are valid in ArrowFollow-up to #71.
Test plan
test_decimal_too_many_parameters_rejected— verifies 3-param and 4-param decimals return clear error messagestest_decimal_negative_scale_valid— verifiesdecimal(10, -2)producesDecimal128(10, -2)cargo test --lib types— 28 tests)