Fixed: profile image upload issue on details page(#320)

[ymaheshwari1]

Related Issues

#320

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @ymaheshwari1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where profile images were not displaying correctly on the details page. The fix involves a targeted modification to the Content Security Policy, enabling the application to properly render images that are embedded using data: URIs.

Highlights

• Content Security Policy Update: The Content-Security-Policy in firebase.json has been updated to include data: in the img-src directive. This change is crucial for allowing profile images, which may be uploaded as data: URIs, to be displayed correctly on the details page.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the data: source to the img-src directive in the Content Security Policy (CSP) to fix a profile image upload issue. While this change is correct for the intended purpose, the review identifies several critical security vulnerabilities in the existing CSP, such as the use of 'unsafe-inline' and 'unsafe-eval', which significantly increase the risk of XSS attacks. I've provided suggestions to immediately improve the img-src directive by removing invalid and dangerous sources. I strongly recommend a follow-up to address the other critical security risks in the CSP. Additionally, the CSP configuration is duplicated across three environments, which is a maintainability concern, although this may be a limitation of the firebase.json format.