Add an INI mode #514
Open
Add an INI mode #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think it might actually be better to accept some duplication over having this many conditionals inside the lexer. Whatever definitions can be reused could placed in a shared lexer module. Having everything in one lexer makes it very hard to reason about. |
Contributor
Author
|
Hmm I think I might have a nice way to avoid too much reuse, will start toying with it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May I present to you, the ultimate nightmare lexer.
Basically, we've got four very, very different syntaxes to support, but they have enough common ground that leaving them in fully different modes results in a ton of ugly duplication.
I was originally going to play around with an okay-ish editorconfig bundle, but then I realized the file didn't look pretty to edit and got a bit sidetracked...