Open
Conversation
added 2 commits
February 14, 2020 13:02
added 12 commits
February 14, 2020 13:45
dmanno
requested changes
Jul 6, 2020
Contributor
dmanno
left a comment
There was a problem hiding this comment.
Glad you moved to --with and replaced the clunky block for strict-checks. Please modify "checks" to be more descriptive. ("strictchecks", "strict_checks", or the like). What is really happening is that it forces any giver or taker to have their primary group match their uid (ex. dmanno:dmanno), so maybe even "strict_owner"?
dmanno
reviewed
Jul 6, 2020
Contributor
|
OK, apologies I should have caught this in my first pass. We shouldn't change behavior in terms of default build options, so let's modify to use the --without strict_checks as an option and the default behavior is to use --with strict_checks. |
Author
|
Changed default to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important Notes:
give-3.1v3.1INSTALLfile