SDK changes - Phase1 #108
Open
SDK changes - Phase1 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmita-poddar-hpe
changed the title
traghavendra
reviewed
Sep 3, 2025
hpe3parclient/client.py
Outdated
| return host, hostname | ||
|
|
||
|
|
||
| def queryHostReturnHostname(self, iscsi_iqn=None, wwns=None): |
There was a problem hiding this comment.
Please use iscsi_iqns. because iqn can be one or more
traghavendra
requested changes
Sep 3, 2025
traghavendra
reviewed
Sep 8, 2025
hpe3parclient/client.py
Outdated
| return None | ||
|
|
||
|
|
||
| def _get_key_value(self, hpe3par_keys, key, default=None): |
There was a problem hiding this comment.
The variable "hpe3par_keys" is used by cinder. So this function should be part of common.py
traghavendra
reviewed
Sep 8, 2025
hpe3parclient/client.py
Outdated
| rcg_name = vol_details.get('rcopyGroup') | ||
| return rcg_name | ||
|
|
||
| def getStorageSystemIdName(self): |
There was a problem hiding this comment.
The variables 'id' and 'name' are same in all arrays i.e 3par, primera, Alletra 9000 and Alletra MP.
thus, this function can be removed & getStorageSystemInfo() can be used (like in original cinder code).
traghavendra
reviewed
Sep 8, 2025
hpe3parclient/client.py
Outdated
| return info['id'], info['name'] | ||
|
|
||
|
|
||
| def getWsApiVersionBuild(self): |
There was a problem hiding this comment.
same comment as for previous function getStorageSystemIdName().
this function can be removed & getWsApiVersion() can be used (like in original cinder code).
traghavendra
reviewed
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flows - initialize_connection, create_volume, delete_volume, create_snapshot, delete_snapshot, extend_volume (increase size of vol), create_volume_from_snapshot, create_cloned_volume.