Skip to content

Pages & popups refactoring#267

Merged
ai merged 20 commits intomainfrom
pages
Apr 2, 2025
Merged

Pages & popups refactoring#267
ai merged 20 commits intomainfrom
pages

Conversation

@ai
Copy link
Copy Markdown
Contributor

@ai ai commented Oct 18, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Pull request auto-reviewer

  • Think about code testing.

  • Think about moving code to core/. What code will also be useful on other platforms?

  • Think about HTML semantics.

  • Think about accessibility. Try to search for a11y recommendations for your case. Think about how screen reader users will use the tool. Is it easy to use on a screen with bad contrast?

  • The UI was checked in Chrome and Firefox (and Safari or Epiphany if you have them).

  • Think about making types more precise. Can you better explain data relations by type?

@github-actions
Copy link
Copy Markdown
Contributor

Pull request auto-reviewer

  • Don’t rush. Check all changes in PR again.

  • Run pnpm test.

  • Think about changing documentation.

    • If you added a script to scripts/, add a comment with a description.
    • If you added a new folder, add its description to the project’s README.md.
    • If you added config, describe how we use this tool in the config’s comment.
    • Try to focus on “why?”, not “how?”.
  • If you added a new dependency, check our requirements.

@ai ai force-pushed the pages branch 2 times, most recently from 8fc157f to 703b7e6 Compare October 21, 2024 22:52
@ai ai force-pushed the pages branch 3 times, most recently from 3a4837c to a738beb Compare November 5, 2024 00:28
@ai ai force-pushed the main branch 3 times, most recently from e398ad3 to 5e4f0ac Compare January 12, 2025 12:23
@ai ai force-pushed the main branch 2 times, most recently from 09867f2 to c9341e2 Compare March 18, 2025 20:56
@ai ai force-pushed the pages branch 4 times, most recently from e02d57e to c1cfef5 Compare March 31, 2025 19:13
@ai ai marked this pull request as ready for review April 2, 2025 23:54
@ai ai merged commit bb21525 into main Apr 2, 2025
11 checks passed
@ai ai deleted the pages branch April 2, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant