Update NEWS.md with recent bug fixes for ED calculations#189
Merged
Conversation
Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/c2724f6d-4710-447d-8218-01d00de1d28d Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Claude created this pull request from a session on behalf of
hreinwald
April 13, 2026 14:17
View session
hreinwald
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents two critical bug fixes from PR #188 related to effective dose (ED) calculations in the drc package.
Changes
Logistic model absolute ED calculation: Added documentation for fix to
logistic()model'sedfctfunction whentype="absolute". The logistic model uses opposite b-sign convention from log-logistic (b < 0 = increasing), soEDhelper()'s automatic p-swap for b < 0 produces incorrect results. Fix uses inline absolute-to-relative conversion instead.Model-level edfct derivatives for absolute ED: Added documentation for fix to gradient calculations in
braincousens(),fplogistic(),llogistic(),llogistic2(),lnormal(),weibull1(), andweibull2(). Whentype = "absolute", these functions incorrectly set ∂ED/∂c and ∂ED/∂d to 0, violating the chain rule since the absolute-to-relative conversion makes p depend on c and d. Fix computes these partials via central differences.Both fixes ensure correct standard error estimates for absolute-type ED calculations across all affected dose-response models.