Conversation
Integrated enhancement from DoseResponse#45: - Added errbar.col parameter to plot.drc() function - Error bars now match curve colors by default (when errbar.col=NULL) - Maintains backward compatibility (errbar.col="black" for old behavior) - Updated barFct functions to accept col parameter - Updated documentation in R/plot.drc.R and man/plot.drc.Rd - Updated NEWS.md with new feature description Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/9afb7ff7-fdbc-426a-b8bd-82ef3c756602 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
- Updated version from 3.3.0.03 to 3.3.1 in DESCRIPTION - Updated date to 2026-04-08 - Reorganized NEWS.md to list changes under version 3.3.1 - Removed outdated version reference in Changes section Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/08c4c988-b4dd-4a76-8fd8-74c231e6f539 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Empty function without purpose and without any active code. Was removed.
Restored and enhanced documentation for the MAX function, detailing parameters, return values, and usage examples.
- Restored the complete drc 3.3.0.03 section with all features, bug fixes, and changes - Added new drc 3.3.1 section on top with only the error bar color enhancement Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/78c2efb0-45dc-4a14-abac-ae3d99a92315 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Removed docs html for removed genRetFct. This was an empty function with no functional code in it. Clean up step.
Removed docs md for removed `genRetFct`. This was an empty function with no functional code in it. Clean up step.
Delete man/genRetFct.Rd
Delete docs/reference/genRetFct.html
…esponse Updated drc.plot function with the the feature that the error bar colors now match curve colors. This fix was suggested here: DoseResponse#45
…evel edfct functions When type='absolute', the edfct functions in model files set derivatives for c (lower limit) and d (upper limit) to 0. This is incorrect because the absolute-to-relative conversion makes p depend on c and d, requiring chain-rule corrections. Use central differences to compute correct c and d derivatives for absolute type in all affected model files. Fixes: braincousens.R, fplogistic.R, llogistic.R, llogistic2.R, lnormal.R, weibull1.R, weibull2.R, logistic.R Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/7ea3ad01-6a69-4d8a-8c99-5b419f07b01f Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
…legation path Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/7ea3ad01-6a69-4d8a-8c99-5b419f07b01f Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
…d incorrect p-swap The logistic model has opposite b-sign convention from log-logistic: b < 0 means increasing (not decreasing). EDhelper swaps p for b < 0, which is correct for log-logistic but wrong for logistic. Replace with inline absolute-to-relative conversion that skips the p-swap. Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/801bd853-cb45-4ae2-8e75-c28dae361ad5 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
…solute-ed Fix model-level edfct derivatives for absolute ED type
Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/c2724f6d-4710-447d-8218-01d00de1d28d Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Update NEWS.md with recent bug fixes for ED calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
drcpackage to version 3.3.1, introducing a new feature for error bar coloring in plots and fixing several important bugs related to effective dose (ED) calculations and derivatives, especially for the "absolute" ED type in multiple models. It also includes general code cleanups and improved package startup messaging.New Features
plot.drc(): Error bars intype = "bars"plots now match the curve colors by default. A newerrbar.colparameter allows manual control of error bar colors; settingerrbar.col = "black"restores the previous behavior. [1] [2] [3] [4] [5] [6]Bug Fixes: ED Calculation and Derivatives
logistic()model ED calculation fortype="absolute": Theedfctfunction now correctly handles absolute-to-relative conversion inline, avoiding the incorrect p-swap logic fromEDhelper(), which was not applicable to the logistic model's parameter conventions. [1] [2] [3]edfctderivatives for absolute ED type inbraincousens(),fplogistic(),llogistic(),llogistic2(),lnormal(),weibull1(), andweibull2(): Whentype = "absolute", the chain rule was previously ignored, resulting in incorrect zero derivatives for parameters c and d. Now, these derivatives are computed using central differences on closures that capture the full ED computation path, ensuring correct gradient calculations. [1] [2] [3] [4] [5] [6]General Improvements and Maintenance
genRetFct.R/max.R. [1] [2] [3] [4] [5]See the
NEWS.mdfile for a detailed changelog.