Stop ScaleWorkers dialog overwriting user input on worker-state update#1
Open
Stop ScaleWorkers dialog overwriting user input on worker-state update#1
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hrishioa
requested changes
Jul 4, 2024
Owner
hrishioa
left a comment
hrishioa
left a comment
There was a problem hiding this comment.
So this approach works, but maybe it relies on the navbar re-rendering completely to update the state (so if it doesn't the state for workercount becomes stale). Should we useMemo?
Collaborator
Author
|
@hrishioa oh yes! makes sense..I have pushed another commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The "Number of Workers" field was being overwritten by updates from outside the dialog, causing users to lose their manually entered worker count.
Intended UI Fix:
Ensure the user's manually entered worker count is preserved, even when external updates occur.
Code Changes:
useRefforworkerCountto keep track of the latest values without triggering re-renders.useEffectto set the initialscaleCountbased on the value stored in the ref.