-
Notifications
You must be signed in to change notification settings - Fork 264
Create a simple makefile and allow regressions to use it. #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ad30ca6
to
b364cc0
Compare
Thanks! @jarzec you're the expert on that, do you think this will improve regression tests, and do you approve merging this PR? |
Some context My thoughts On the other hand, adding a command line option to provide the executable to the @hsutter What do you say? |
I'm old-school and I wanted something quick and dirty, so I added a Makefile. Quick and dirty is better than nothing and I was sick and tired of having to get the incantation right on the command line. With that said, you're probably right that a CMake setup is better. I'll take a look around the related projects. I did set up a CMake system to compile cpp2 files in https://github.com/threeifbyair/advent2024, but that was really my first experience with CMake (I've spent the last ten-plus years with proprietary build tools!) so it may not be all that good. |
I also prefer makefiles for a quick setup. Usually they also do not block the path for manual compilation. Since the project is kept quite simple. Why not have both. A makefile and cmake file can exist next to each other. Use the simple makefile for the ci and cmake can be used to integrate it into other projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the discussion in the comments I agree that a Makefile wouldn't hurt.
It is already a nice step towards more internal tooling.
One of the frustrating things about cppfront is that I always have to remember the precise incantation to build cppfront. In addition, the regression tests always build cppfront whether or not it needs to be built.
This PR adds a simple Makefile. Nothing special and explicitly marked as optional. In addition, it allows the regression tests to be run with a pre-built version of cppfront. This allows us (for instance) to build a sanitized cppfront and run it through the regressions to see if we get any memory or undefined behavior errors.