change: separate out tls feature flags#67
Merged
Fishrock123 merged 1 commit intohttp-rs:mainfrom Feb 12, 2021
Merged
Conversation
Member
Author
|
@JEnoch sorry for being slow, does this look good to you? |
0715b23 to
cc0dfe0
Compare
Contributor
|
@Fishrock123 yes, looks good to me! |
cc0dfe0 to
f220770
Compare
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer. Fixes: http-rs#54
f220770 to
3c7593f
Compare
Contributor
|
This seems to break when both "native-tls" feature and "rustls" feature are enabled, or when both "native-tls" feature and "rustls" feature are disabled.
See also cargo reference: https://doc.rust-lang.org/nightly/cargo/reference/features.html |
Contributor
|
I filed a fix to surf (http-rs/surf#282), and I plan to send a similar patch to http-client later. EDIT: filed #69 to fix http-client |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successor to #53, this separates out the tls feature flags, which should be nicer.
Fixes: #54