Open
Conversation
changed OWNER to myself
build.sh back to zixia
Owner
|
Dear @jaydouble , thank you very much for the contribution; the code looks good! However, I think it would be better not to introduce another parameter for SMF, which might make it more complicated. Could you please provide a helper script for loading the data from the file and outputting the string which can satisfy the It would be perfect like this: $ export SMF_CONFIG=`./scripts/smf-config-file.sh smf.config`
# ... |
Author
|
Maybe better to let the user chose: export SMF_CONFIG=$(cat smf.config)
docker run -e SMF_CONFIG ....If he want to use a config file variable, like when using a docker swarm he can use: version: "3.8"
volumes:
config:
services:
smf:
image: zixia/simple-mail-forwarder
volumes:
- config:/config
ports:
- 25:25
environment:
SMF_CONFIG_FILE: "/config/forwards"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added
SMF_CONFIG_FILEvariable to use a file for config.to add file, be creative, you can use a bind mount, but also a secret.
A bit easier to read if you have more than one forward to make. Maybe also a bit less change for misstakes.