Open
Conversation
This commit migrates SONiC from Redis to Valkey, a Redis-compatible fork. Changes include: - Replace src/redis with src/valkey for building Valkey packages - Update rules/redis.mk and rules/redis.dep to rules/valkey.mk and rules/valkey.dep - Update docker-database to use valkey-server and valkey-tools - Update docker-base-* Dockerfiles to install valkey-tools instead of redis-tools - Update supervisord.conf.j2 to run valkey-server with valkey user - Update docker-database-init.sh to use valkey user for permissions - Update redis-cli wrapper to call valkey-cli - Update rules/docker-database.mk to reference valkey-cli - Update sonic-dpu-mgmt-traffic.sh to use valkey-cli Valkey is API-compatible with Redis, so existing code using Redis commands and protocols will continue to work without modification. Co-Authored-By: sunrusta@cisco.com <sunesh@yahoo.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Migrate SONiC from Redis to Valkey. Valkey is a Redis-compatible fork that serves as a drop-in replacement, providing continued open-source development and community support.
Work item tracking
How I did it
Replaced all Redis references with Valkey equivalents:
src/redis/build directory withsrc/valkey/(Valkey 8.0.1 from Debian repos)rules/redis.mk→rules/valkey.mk,rules/redis.dep→rules/valkey.depvalkey-toolsinstead ofredis-toolsvalkey-serverandvalkey-tools/etc/redis/redis.confto/etc/valkey/valkey.confredistovalkeyredis-cliwrapper script to callvalkey-clisonic-dpu-mgmt-traffic.shto usevalkey-cliHow to verify it
redis-cliwrapper correctly invokesvalkey-cliImportant items for reviewer to verify:
packages.trafficmanager.net/public/valkey/for buster/stretch architectures (armhf, arm64, amd64)valkeyuser/group on installation/etc/valkey/valkey.confis correct for Valkey packageWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Migrate from Redis to Valkey (Redis-compatible fork) for database services
Link to config_db schema for YANG module changes
N/A - No YANG model changes
A picture of a cute animal (not mandatory but encouraged)
Additional Information