Skip to content

Upgrade SAI API from version 0.9.4 to 1.12#4

Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1765476644-upgrade-sai-api-1.12
Open

Upgrade SAI API from version 0.9.4 to 1.12#4
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1765476644-upgrade-sai-api-1.12

Conversation

@devin-ai-integration
Copy link

Why I did it

Upgrade the SAI API version from 0.9.4 to 1.12 across multiple platform files to support newer SAI features and compatibility.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated SAI version definitions in the following files:

  1. SAI_VER updates (0.9.4 → 1.12):

    • platform/vs/libsaithrift-dev.mk
    • platform/mellanox/libsaithrift-dev.mk
    • platform/barefoot/libsaithrift-dev.mk
  2. Vendor-specific SAI implementation versions:

    • platform/mellanox/mlnx-sai.mk: SAIBuild2505.33.0.10 → SAIBuild2505.1.12.0
    • platform/nvidia-bluefield/recipes/dpu-sai.mk: SAIBuild0.0.45.0 → SAIBuild1.12.0.0
    • platform/components/docker-gbsyncd-broncos.mk: 3.12 → 1.12
  3. SAI Redis adapter: rules/sairedis.mk: 1.0.0 → 1.12.0

  4. Dockerfile comments: Updated SAI version references in build container templates

How to verify it

Build the SONiC image for affected platforms and verify SAI packages are correctly versioned.

⚠️ IMPORTANT - Human Review Required:

  • Verify MLNX_SAI_VERSION (SAIBuild2505.1.12.0) is the correct SAI 1.12-compatible version from Mellanox/NVIDIA
  • Verify DPU_SAI_VERSION (SAIBuild1.12.0.0) is the correct SAI 1.12-compatible version for Bluefield DPU
  • Verify LIBSAI_BRONCOS_VERSION change (3.12 → 1.12) - this appears to be a version downgrade and may be incorrect
  • Confirm packages exist at the constructed download URLs

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Upgrade SAI API version from 0.9.4 to 1.12 across all platform configurations

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)


Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/9df5126b5df646cbb335a52d1de5dbb7
Requested by: Arthur Poon (arthur.poon@cognition.ai) / @arthurkkp-cog

- Update SAI_VER to 1.12 in platform/vs/libsaithrift-dev.mk
- Update SAI_VER to 1.12 in platform/mellanox/libsaithrift-dev.mk
- Update SAI_VER to 1.12 in platform/barefoot/libsaithrift-dev.mk
- Update MLNX_SAI_VERSION to SAIBuild2505.1.12.0 in platform/mellanox/mlnx-sai.mk
- Update DPU_SAI_VERSION to SAIBuild1.12.0.0 in platform/nvidia-bluefield/recipes/dpu-sai.mk
- Update LIBSAI_BRONCOS_VERSION to 1.12 in platform/components/docker-gbsyncd-broncos.mk
- Update LIBSAIREDIS_VERSION to 1.12.0 in rules/sairedis.mk
- Update SAI version comments in Dockerfile templates

Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants