Fix libnl3 build by skipping tests in non-cross build environment#7
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Fix libnl3 build by skipping tests in non-cross build environment#7devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
The libnl3 tests fail in container environments due to network namespace permission/capability limitations. This change adds DEB_BUILD_OPTIONS=nocheck and -Pnocheck to the dpkg-buildpackage command for non-cross builds, similar to how cross builds already skip tests. This fix is necessary to build the SONiC image with the FRR bug fix patches applied. The FRR package (frr_10.3-sonic-0_amd64.deb) with all 62 patches was successfully built after this change. Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The libnl3 package tests fail in container build environments due to network namespace permission/capability limitations. The test failure occurs in
tests/nl-test-util.cwith the error:Assertion 'r == 0' failed: r == -10, 0 == 0.This blocks the SONiC image build process, preventing the FRR package (with 62 bug fix patches) from being built.
Work item tracking
How I did it
Added
DEB_BUILD_OPTIONS=nocheckand-Pnocheckto the dpkg-buildpackage command for non-cross builds, mirroring the existing behavior for cross builds which already skip tests with-Pcross,nocheck.How to verify it
make SONIC_BUILD_JOBS=4 target/sonic-vs.img.gzWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Skip libnl3 tests in non-cross builds to fix container environment build failures
Link to config_db schema for YANG module changes
N/A
Human Review Checklist
Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/38579f6ac4a6427e9da281b441bf3136
Requested by: Arthur Poon (arthur.poon@cognition.ai) / @arthurkkp-cog