WIP: Remove use of warden and use omniauth-github in preparation for supporting GitLab#157
WIP: Remove use of warden and use omniauth-github in preparation for supporting GitLab#157stanhu wants to merge 1 commit intohuboard:masterfrom
Conversation
|
Hmmm interesting I will have to dig into this a little bit more when I have time. I ran into some problems with warden, specifically warden-github and it boiled down to SSL issues Also, I'm not sure how we are going to support GitLab right now. If HuBoard should be one app or if it's completely separate "builds" of HuBoard and we have something like gitlab.huboard.com and possible github.huboard.com and so one That's actually pretty interesting, I kind of like that idea, huboard.com could move to static site that's kind of like a train switch to the different subdomains. Would love to hear some thoughts on that... |
|
@stanhu I am actively looking into this right now. Proper OAuth flow is way more complex than I thought. Just want to let you know that we didn't forget about you. Let me know if you have some free time to skype or chat about how we want to move forward with this PR Cheers,
|
|
@rauhryan Somehow I missed this. Sure, maybe we can discuss this this week. |
|
Fortunately, some of the complexity to which @rauhryan was referring was due to a quirk in GitHub Also FYI, #214 adds some OAuth complexity to support deploying review apps. We'll need to implement equivalent behavior with OmniAuth. |
|
Closing as HuBoard for GitLab is no longer in development. |
Relates to huboard/ghee#37.