Fix gem install mailcatcher

[dahlbyk]

vagrant provision is failing for me since b68856a.

Error 1

==> default: Error: Validation of Exec[mail-catcher] failed: 'gem install mailcatcher' is not qualified and no path was specified. Please qualify the command or specify a path. at /tmp/vagrant-puppet/manifests-846018e2aa141a5eb79a64b4015fc5f3/base.pp:18

• Fixed with path.

Error 2

==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: Building native extensions.  This could take a while...
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: ERROR:  Error installing mailcatcher:
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns:  ERROR: Failed to build gem native extension.
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: 
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns:         /usr/bin/ruby1.9.1 extconf.rb
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require': cannot load such file -- mkmf (LoadError)
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns:  from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns:  from extconf.rb:1:in `<main>'
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: 
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: 
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: Gem files will remain installed in /var/lib/gems/1.9.1/gems/json-1.8.3 for inspection.
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: Results logged to /var/lib/gems/1.9.1/gems/json-1.8.3/ext/json/ext/generator/gem_make.out

• Fixed with apt-get install ruby-dev.

Error 3

==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns: ERROR:  Error installing mailcatcher:
==> default: Notice: /Stage[main]/Main/Exec[mail-catcher]/returns:      mime-types-data requires Ruby version >= 2.0.

• Fix = ?

[dahlbyk]

I assume @discorick had installed the MailCatcher gem after provisioning, through rbenv. I tried pretty hard in #201 (comment) to use our newly-installed rbenv to run bundle install as part of provisioning, but couldn't figure it out. Maybe now is the time? Or we can simply punt and make MailCatcher an optional, manual install after provisioning.

[discorick]

@dahlbyk everything should now be good to go! I just did a clean vagrant up . Can you give it a shot when you have a chance ?

EDIT: you will need to puppet-provisioner install

[dahlbyk]

Up and running now after a fully clean install!

It looks like a clean install includes a Bundler bump:

diff --git a/Gemfile.lock b/Gemfile.lock
index 774f9c1..63432cb 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -497,4 +497,4 @@ DEPENDENCIES
   wkhtmltopdf-heroku

 BUNDLED WITH
-   1.11.2
+   1.12.5

Should I push that change here?

[discorick]

Awesome!

It looks like a clean install includes a Bundler bump

Strange, I didn't get one I don't think. Did you run bundle update or bundle install ?

[dahlbyk]

Strange, I didn't get one I don't think. Did you run bundle update or bundle install ?

bundle install

bundler --version says 1.12.5, so presumably that's what a clean puppet install today installs?

[discorick]

Hmm, did you bundle install on the appliance or the host machine ?

[dahlbyk]

Hmm, did you bundle install on the appliance or the host machine ?

In the VM. I assume if you do a gem update bundler you'll get the same. Our Gemfile.lock has: bundler (>= 1.3.0, < 2.0).

[discorick]

I did a complete wipe of the VM and built from scratch. Just wondering why we ended up in different states after the initial build... Ill take a look to confirm .

[dahlbyk]

Bump BUNDLED WITH (to 1.12.5)

@rauhryan as in #315 (comment), keep an eye on this when it comes into enterprise.