Skip to content

Restore truncated url #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denphi wants to merge 1 commit into
base: 2.4-main
Choose a base branch
from
Open

Restore truncated url #1854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions core/components/com_courses/models/asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,18 @@ public function path($course=0, $withUrl=true)
// Override path for url/link type assets
if (in_array(strtolower($this->get('type')), array('form', 'link', 'url')))
{
$path = $this->get('url');
$path = $this->get('url'); // may be truncated (VARCHAR 255)
$content = $this->get('content'); // contains full URL
// Heuristic: truncated URLs usually hit the column limit
if ($path !== null && strlen($path) >= 250)
{
// Try to recover the full URL from content
if (preg_match('~https?://[^\s"\')<>]+~i', $content, $m))
{
$path = $m[0];
}
}
}

return $path;
}

Expand Down