Merged
Conversation
added 3 commits
March 16, 2026 03:21
- Add 3.13/3.14 classifiers to pyproject.toml - Extend CI test matrix to include 3.13 and 3.14 - Modernize type annotations: replace typing.Optional/List/Dict/Tuple/Union with built-in generics across 11 files - Add Python version requirement to README Made-with: Cursor
tensorflow and vllm don't ship cp314 wheels yet, which breaks `pip install .[testing]` on Python 3.14. Install a reduced set of extras on 3.14 while keeping full coverage on 3.10-3.13. Made-with: Cursor
Key optional deps (tensorflow, vllm) lack cp314 wheels. Keep only 3.13 for now; 3.14 can be added once the ecosystem catches up. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Datatrove only declares and tests support for Python 3.10, 3.11, and 3.12, even though Python 3.13 (Oct 2024) is in active maintenance. Users on newer Python versions see missing classifiers on PyPI and have no CI coverage guaranteeing compatibility.
Solution
Programming Language :: Python :: 3.13classifier topyproject.toml..github/workflows/testing.ymlto include 3.13.typing.Optional,typing.List,typing.Dict,typing.Tuple, andtyping.Unionwith built-in generics (X | None,list,dict,tuple,X | Y) andcollections.abc(Callable,Sequence). The project already targets>=3.10, so these are all safe.Notes
Python 3.14 is not included yet because key optional dependencies (
tensorflow,vllm) don't shipcp314wheels. Sincerequires-python = ">=3.10.0"already permits 3.14 installs, users can still install and use datatrove on 3.14 -- we just don't test it in CI yet.Testing