[Modular] Consolidate load_default_components into load_components
#12217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DN6
commented
Aug 22, 2025
| ] | ||
| self.load_components(names=names, **kwargs) | ||
| # Consolidated into load_components - just call it without names parameter | ||
| logger.warning("`load_default_components` is deprecated. Please use `load_components()` instead") |
There was a problem hiding this comment.
@yiyixuxu Up to you whether we just remove the method all together or deprecate. Fine with either.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
approved these changes
Aug 22, 2025
| ] | ||
| self.load_components(names=names, **kwargs) | ||
| # Consolidated into load_components - just call it without names parameter | ||
| logger.warning("`load_default_components` is deprecated. Please use `load_components()` instead") |
|
@bot /style |
|
Style bot fixed some files and pushed the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
load_default_componentsis a thin wrapper aroundload_componentsand just deals with the case whenname=None. IMO better to just consolidate it intoload_componentsFixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.