-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[core] use kernels
to support _flash_3_hub
attention backend
#12236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sayakpaul
wants to merge
10
commits into
main
Choose a base branch
from
fa3-from-kernels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
827fc15
feat: try loading fa3 using kernels when available.
sayakpaul a0177eb
up
sayakpaul ac43e84
Merge branch 'main' into fa3-from-kernels
sayakpaul bc40971
change to Hub.
sayakpaul 87d0879
up
sayakpaul 2bb3796
up
sayakpaul 4e69d42
up
sayakpaul 595ae6b
Merge branch 'main' into fa3-from-kernels
sayakpaul 548f56e
Merge branch 'main' into fa3-from-kernels
sayakpaul 0e7eac0
Merge branch 'main' into fa3-from-kernels
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
from ..utils import get_logger | ||
from .import_utils import is_kernels_available | ||
|
||
|
||
logger = get_logger(__name__) | ||
|
||
|
||
_DEFAULT_HUB_ID_FA3 = "kernels-community/vllm-flash-attn3" | ||
|
||
|
||
def _get_fa3_from_hub(): | ||
if not is_kernels_available(): | ||
return None | ||
else: | ||
from kernels import get_kernel | ||
|
||
try: | ||
flash_attn_3_hub = get_kernel(_DEFAULT_HUB_ID_FA3) | ||
return flash_attn_3_hub | ||
except Exception as e: | ||
logger.error(f"An error occurred while fetching kernel '{_DEFAULT_HUB_ID_FA3}' from the Hub: {e}") | ||
raise |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than loading the kernel every time we invoke flash attention, it would be better to import the function at the top of the file, similar to the other FA backends.
diffusers/src/diffusers/models/attention_dispatch.py
Lines 63 to 68 in e58711e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but see
#12236 (comment)
We shouldn’t make remote calls to the Hub unless requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can enable user permission via env variable similar to GGUF kernels
diffusers/src/diffusers/quantizers/gguf/utils.py
Line 33 in 87b800e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God that simplifies a lot of stuff. Thanks, Dhruv!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wondering if we just add a
DIFFUSERS_ENABLE_HUB_KERNELS
constant that is used for all kernel cases.