fix(DDIM scheduler): use correct dtype for noise#742
fix(DDIM scheduler): use correct dtype for noise#742patrickvonplaten merged 3 commits intohuggingface:mainfrom
Conversation
Otherwise, it crashes when eta > 0 with float16.
|
Should we add a right now the different calls to randn are subtly inconsistent in whether and how they pass dtype or device. Having a single implementation would provide one place for those fiddly details, especially if there are things that have to be different on certain platforms like |
|
The documentation is not available anymore as the PR was closed or merged. |
a) this is not an informative failure message. sod off, stylebot. |
I think that makes sense, and we should ensure that all calls use the generator. If @patrickvonplaten and @anton-l agree we can follow up in a new PR :) |
|
I think this fix can potentially be applied to sde-ve and sde-vp schedules too |
patrickvonplaten
left a comment
There was a problem hiding this comment.
Great fix! Thanks!
Otherwise, it crashes when eta > 0 with float16.
…ce#742) Co-authored-by: dan <dan@nod-labs.com> Co-authored-by: powderluv <powderluv@users.noreply.github.com>
Otherwise, it crashes when eta > 0 with float16.
Otherwise, it crashes when eta > 0 with float16.
Follow-up to #511.