Skip to content

⚡️ uint8array set method instead of spread #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ uint8array set method instead of spread #1667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/hub/src/utils/XetBlob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,11 @@ export class XetBlob extends Blob {
totalFetchBytes += result.value.byteLength;

if (leftoverBytes) {
result.value = new Uint8Array([...leftoverBytes, ...result.value]);
leftoverBytes = undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the leftoverBytes = undefined part is important

Copy link
Member

@coyotte508 coyotte508 Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make the function into a combineUint8Arrays helper? ( a dedicated file in this folder)

const leftoverBytesLength: number = leftoverBytes.length;
const combinedBytes = new Uint8Array(leftoverBytesLength + result.value.length);
combinedBytes.set(leftoverBytes);
combinedBytes.set(result.value, leftoverBytesLength);
result.value = combinedBytes;
}

while (totalBytesRead < maxBytes && result.value.byteLength) {
Expand Down