-
Notifications
You must be signed in to change notification settings - Fork 493
Add BBoxMaskPose to download count #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. left 2 small comments, let me know if they are not clear! 🤗
repoName: "BBoxMaskPose", | ||
repoUrl: "https://github.com/MiraPurkrabek/BBoxMaskPose", | ||
filter: false, | ||
countDownloads: `path_extension:"pth"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all the three models used for inference or is one used at a time?
The reason I ask is, there are currently three different model checkpoint in the repo: https://huggingface.co/vrg-prague/BBoxMaskPose/tree/main
and the download counter will +=1 download counter for each hit, i.e. if all three are used for single inference, it'd result in +=3 which would make downloads inaccurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, @Vaibhavs10 .
Yes, all 3 models are needed to run the whole method -- it consists of their iterative usage and smart integration. However, all models could also work as standalone models if the user does not want to use them in the loop.
Therefore, it make sense to me to have all models in the same repo as they are connected to the same paper and together form the main method.
On the other hand, it also make sense to count downloads for each model. A user can download only one of the models and it should be counted.
Let me know if you see it differently or if I should change anything.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating here. Let's wait for one more approval before merge.
Add BBoxMaskPose paper to download count.
HuggingFace link - BBoxMaskPose on HuggingFace
GitHub link - BBoxMaskPose on GitHub