Skip to content

Changing output to follow Transformers v5 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changing output to follow Transformers v5 #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scattermoe/torch-ext/scattermoe/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ def forward(self, layer_input):
gates=routing_weights
)
layer_output = layer_output.view(bsz, length, emb_size)
return layer_output, router_logits
return layer_output

Comment on lines +51 to 52
Copy link
Collaborator

@MekkCyber MekkCyber Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we don't need the router_logits in the kernel ?

Copy link
Contributor Author

@shawntan shawntan Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've understood, the new transformers v5 tracks the router_logits via some annotations to the main class: _can_record_outputs and OutputRecorder (huggingface/transformers#40822 (comment)). @ArthurZucker has confirmed those annotations will be added to GraniteMoe, making the output signature same as all the other MoE models, where the router logits are similarly tracked via those annotations.

I'm not sure if the underlying mechanism that tracks the logits for v5 will work with the kernel, but it's hard to test since for GraniteMoeHybrid, we need mamba_ssm to be compatible with v5.

Copy link
Collaborator

@MekkCyber MekkCyber Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifications @shawntan, I don't get though why it's hard to test ?

Copy link
Contributor Author

@shawntan shawntan Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Mamba's been updated, I've tested it. Sorry about that.

Everything seems good to go!