Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
16b5b24
misc(build-pr): update to actions/checkout v5
mfuntowicz Nov 17, 2025
ea02c95
misc(build-pr): ok let's try to setup the pipeline for windows
mfuntowicz Nov 18, 2025
9f79085
misc(build-pr): missing setup-python
mfuntowicz Nov 18, 2025
046d735
misc(build-pr): updating code from bash to Powershell
mfuntowicz Nov 18, 2025
184f0d3
misc(build-pr): debug
mfuntowicz Nov 18, 2025
f06cb07
misc(build-pr): enable only on pr to be able to retrieve title
mfuntowicz Nov 18, 2025
e4085e4
misc(build-pr): ok let's build?
mfuntowicz Nov 18, 2025
5399590
misc(build-pr): invalid escaping
mfuntowicz Nov 18, 2025
2cc10fd
misc(build-pr): invalid escaping
mfuntowicz Nov 18, 2025
1623b21
misc(build-pr): bllll
mfuntowicz Nov 18, 2025
a847cd2
misc(build-pr): what if I specify the kernel-builder path relative to…
mfuntowicz Nov 18, 2025
41c863a
misc(build-pr): kk
mfuntowicz Nov 18, 2025
a524894
misc(build-pr): kkk
mfuntowicz Nov 18, 2025
0f4d9f0
misc(build-pr): kkkk
mfuntowicz Nov 18, 2025
79d600e
misc(build-pr): kkkkk
mfuntowicz Nov 18, 2025
80732f4
misc(build-pr): kkkkkk
mfuntowicz Nov 18, 2025
95b61a9
misc(build-pr): backend cuda for now
mfuntowicz Nov 18, 2025
8e13eb8
misc(build-pr): trying with cuda13 just in case it's a cuda error
mfuntowicz Nov 19, 2025
2988dfa
misc(build-pr): same with pytorch 2.8?
mfuntowicz Nov 19, 2025
9b4ede2
misc(build-pr): Use a fix on kernel-builder to force `_WIN32` definition
mfuntowicz Nov 19, 2025
fc4d4d6
misc(build-pr): update the fix revision to see?
mfuntowicz Nov 19, 2025
70e1068
Change kernel-builder ref to specific commit
mfuntowicz Nov 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-pr-mac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build-kernel:
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: DeterminateSystems/nix-installer-action@v20
with:
extra-conf: |
Expand Down
97 changes: 97 additions & 0 deletions .github/workflows/build-pr-windows.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
name: Build PR (Windows)
on:
# push:
# branches: ['windows-build-*']
pull_request:
types: [opened, synchronize]
paths-ignore:
- "**/README.md"


concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
build-kernel:
strategy:
matrix:
os: [ windows-2022 ]
python: [ 3.11, 3.12 ]
torch: [
# { version: '2.9.1', cuda: '12.6.3', wheel: '126' },
{ version: '2.9.1', cuda: '12.8.1', wheel: '128' },
# { version: '2.9.1', cuda: '13.0.1', wheel: '130' }
]

runs-on: windows-2022
steps:
- uses: actions/checkout@v5
- name: Validate kernel directory
id: validate
shell: pwsh
run: |
$PR_TITLE = "${{ github.event.pull_request.title }}"
$KERNEL = python .github/workflows/validate-kernel-pr.py "pr" "$PR_TITLE"
if ($LASTEXITCODE -eq 0) {
echo "kernel=$KERNEL" >> $env:GITHUB_OUTPUT
echo "skip=false" >> $env:GITHUB_OUTPUT
} else {
echo "skip=true" >> $env:GITHUB_OUTPUT
}

- name: Kernel Info
if: steps.validate.outputs.skip == 'false'
shell: pwsh
run: |
$KERNEL = "${{ steps.validate.outputs.kernel }}"
Write-Output "Building Kernel: $KERNEL"

- uses: Jimver/cuda-toolkit@v0.2.29
if: steps.validate.outputs.skip == 'false'
id: setup-cuda-toolkit
with:
cuda: ${{ matrix.torch.cuda }}

- name: Setup Python
if: steps.validate.outputs.skip == 'false'
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}

- name: Install PyTorch
if: steps.validate.outputs.skip == 'false'
run: pip install torch --index-url https://download.pytorch.org/whl/cu${{ matrix.torch.wheel }}

- name: Checkout kernel-builder
if: steps.validate.outputs.skip == 'false'
id: checkout-kernel-builder
uses: actions/checkout@v5
with:
repository: huggingface/kernel-builder
ref: 3b6264ec69ef7d336ba7be6d86a137ef238f7e30 # todo(mfuntowicz): remove this when merged in kernel-builder
path: kernel-builder

- name: Cache Rust build
if: steps.validate.outputs.skip == 'false'
uses: actions/cache@v4
with:
path: |
kernel-builder/build2cmake/target
~/.cargo/registry
~/.cargo/git
key: ${{ runner.os }}-rust-debug-${{ hashFiles('kernel-builder/build2cmake/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-rust-debug-

- name: Build build2cmake
if: steps.validate.outputs.skip == 'false'
working-directory: kernel-builder/build2cmake
run: cargo build

- name: Build kernel
if: steps.validate.outputs.skip == 'false'
shell: pwsh
run: |
$KERNEL = "${{ steps.validate.outputs.kernel }}"
& "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\builder.ps1" -Backend cuda -SourceFolder "$KERNEL" -BuildConfig Release -Build
2 changes: 1 addition & 1 deletion .github/workflows/build-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on:
group: aws-highmemory-32-plus-nix
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: DeterminateSystems/nix-installer-action@main
with:
extra-conf: |
Expand Down