Fix GRPO marimo Plotly notebook dependencies#623
Open
AtinChing wants to merge 1 commit intohuggingface:mainfrom
Open
Fix GRPO marimo Plotly notebook dependencies#623AtinChing wants to merge 1 commit intohuggingface:mainfrom
AtinChing wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the three GRPO marimo demos embedded in the LLM course.
They were failing in the browser because the Plotly examples depend on packages like
numpyandpandas, but those dependencies were not declared explicitly. As a result, the marimo embed could get stuck in a broken install state instead of loading normally.To fix that, I added inline dependency metadata to each notebook so marimo knows up front that they require
plotly,numpy, andpandas. I also kept the existing Plotly visualizations, added a table togrpo_length.py, and cleaned up the existing tables in the other two demos so the outputs are easier to inspect.Who can review?
(Feel free to tag members/contributors who may be interested in your PR.)
@burtenshaw as we discussed earlier about me helping out with fixes in the LLM course repo (the files in this PR are the source for some marimo notebooks in chapter 12 of the LLM course)
@mlabonne as the original author of the marimo notebook files' source code.