-
Notifications
You must be signed in to change notification settings - Fork 30.5k
🚨 [v5
] Remove relative position embeddings (for bert like models)
#41170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🚨 [v5
] Remove relative position embeddings (for bert like models)
#41170
Conversation
run-slow: flava, instructblib, mra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly due to me forgetting to update them in my bert refactor PR --> big diff because the whole refactor is included (same for the roberta example)
This comment contains run-slow, running the specified jobs: models: ['models/flava', 'models/mra'] |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
run-slow: instructblip |
This comment contains run-slow, running the specified jobs: models: ['models/instructblip'] |
6046d27
to
0dbd18b
Compare
[For maintainers] Suggested jobs to run (before merge) run-slow: albert, align, altclip, bert, bert_generation, big_bird, blip, blip_2, bridgetower, bros, camembert, canine, chinese_clip, clap, data2vec, dpr |
run-slow: bert, roberta, albert, mra, instructblip, blip_2, flava |
This comment contains run-slow, running the specified jobs: models: ['models/albert', 'models/bert', 'models/blip_2', 'models/flava', 'models/instructblip', 'models/mra', 'models/roberta'] |
Failing slow tests are the same as in main 👀 |
These embedding types are barely used and make the modeling files just more complex without justifying their existence. Position embedding types still exist in a few models; this PR just addresses the
relative_key(_query)
ones.Some stats:
cc @hmellor this should remove any clashes with the kwargs you encountered in vLLM :D