Skip to content

Conversation

vasqu
Copy link
Contributor

@vasqu vasqu commented Sep 25, 2025

These embedding types are barely used and make the modeling files just more complex without justifying their existence. Position embedding types still exist in a few models; this PR just addresses the relative_key(_query) ones.

Some stats:

  • None of the slow tests use them except bert
  • The respective models in those tests together have less than 2k downloads in the last month

cc @hmellor this should remove any clashes with the kwargs you encountered in vLLM :D

@vasqu
Copy link
Contributor Author

vasqu commented Sep 25, 2025

run-slow: flava, instructblib, mra

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly due to me forgetting to update them in my bert refactor PR --> big diff because the whole refactor is included (same for the roberta example)

Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/flava', 'models/mra']
quantizations: [] ...

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@vasqu
Copy link
Contributor Author

vasqu commented Sep 25, 2025

run-slow: instructblip

Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/instructblip']
quantizations: [] ...

@vasqu vasqu force-pushed the remove-relative-positions-bert-likes branch from 6046d27 to 0dbd18b Compare September 25, 2025 18:49
@vasqu vasqu marked this pull request as ready for review September 26, 2025 11:14
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: albert, align, altclip, bert, bert_generation, big_bird, blip, blip_2, bridgetower, bros, camembert, canine, chinese_clip, clap, data2vec, dpr

@vasqu
Copy link
Contributor Author

vasqu commented Sep 26, 2025

run-slow: bert, roberta, albert, mra, instructblip, blip_2, flava

Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/albert', 'models/bert', 'models/blip_2', 'models/flava', 'models/instructblip', 'models/mra', 'models/roberta']
quantizations: [] ...

@vasqu
Copy link
Contributor Author

vasqu commented Sep 26, 2025

Failing slow tests are the same as in main 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants