[loading/saving] Reverse all loading operations when saving #42396
+643
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyrilvallez
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Very nice., missing some fast test in test_core_model_loading! With all the ops that are define in the file to make sure they are all inversible (ex: permute for rope!)
5 tasks
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice but missing tests 👁️ 👁️ !
| # The inverse operation class, will be used when saving the checkpoint | ||
| reverse_op: type[ConversionOps] | ||
| def __repr__(self): | ||
| return f"{self.__class__.__name__}(dim={self.dim})" |
Collaborator
There was a problem hiding this comment.
Suggested change
| return f"{self.__class__.__name__}(dim={self.dim})" | |
| return f"{self.__class__.__name__}(dim={self.dim}, {self.reverse_op}" |
Comment on lines
+416
to
+388
| # Perform renaming op (for a simple WeightRenaming, `self.source_patterns` and `self.target_patterns` can | ||
| # only be of length 1, and are actually the full key names - we also have only 1 single related tensor) | ||
| target_key = self.target_patterns[0] | ||
| collected_tensors = {target_key: self.collected_tensors[self.source_patterns[0]]} |
Collaborator
There was a problem hiding this comment.
not certain this should be done here either API-wise
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Much much much better but missing tests still
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: granite_speech, timm_wrapper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title! We can now revert back all our custom Operation performed during weight loading, and it's the default for BC!