Skip to content

GLM4V - delete duplicate config attribute #42416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2025
+0 −16
Merged

GLM4V - delete duplicate config attribute #42416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62afdd
delete the duplicate attribute
zucchini-nlp Nov 26, 2025
18829e6
also delete from docstring
zucchini-nlp Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/transformers/models/glm4v/configuration_glm4v.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,6 @@ class Glm4vTextConfig(PreTrainedConfig):
Dictionary containing the configuration parameters for the RoPE embeddings. The dictionary should contain
a value for `rope_theta` and optionally parameters used for scaling in case you want to use RoPE
with longer `max_position_embeddings`.
image_token_id (`int`, *optional*):
Token index used as placeholder for image embeddings.
video_token_id (`int`, *optional*):
Token index used as placeholder for video embeddings.

```python
>>> from transformers import Glm4vTextModel, Glm4vConfig
Expand Down Expand Up @@ -217,8 +213,6 @@ def __init__(
tie_word_embeddings: Optional[bool] = False,
attention_dropout: Optional[float] = 0.0,
rope_parameters: Optional[RopeParameters | dict[str, RopeParameters]] = None,
image_token_id: Optional[int] = None,
video_token_id: Optional[int] = None,
**kwargs,
):
self.vocab_size = vocab_size
Expand Down Expand Up @@ -246,8 +240,6 @@ def __init__(
rope_theta = kwargs.get("rope_theta", 10000.0)
standardize_rope_params(self, rope_theta=rope_theta)
rope_config_validation(self, ignore_keys={"mrope_section"})
self.image_token_id = image_token_id
self.video_token_id = video_token_id

super().__init__(tie_word_embeddings=tie_word_embeddings, **kwargs)

Expand Down
8 changes: 0 additions & 8 deletions src/transformers/models/glm4v/modular_glm4v.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,6 @@ class Glm4vTextConfig(PreTrainedConfig):
Dictionary containing the configuration parameters for the RoPE embeddings. The dictionary should contain
a value for `rope_theta` and optionally parameters used for scaling in case you want to use RoPE
with longer `max_position_embeddings`.
image_token_id (`int`, *optional*):
Token index used as placeholder for image embeddings.
video_token_id (`int`, *optional*):
Token index used as placeholder for video embeddings.

```python
>>> from transformers import Glm4vTextModel, Glm4vConfig
Expand Down Expand Up @@ -254,8 +250,6 @@ def __init__(
tie_word_embeddings: Optional[bool] = False,
attention_dropout: Optional[float] = 0.0,
rope_parameters: Optional[RopeParameters | dict[str, RopeParameters]] = None,
image_token_id: Optional[int] = None,
video_token_id: Optional[int] = None,
**kwargs,
):
self.vocab_size = vocab_size
Expand Down Expand Up @@ -283,8 +277,6 @@ def __init__(
rope_theta = kwargs.get("rope_theta", 10000.0)
standardize_rope_params(self, rope_theta=rope_theta)
rope_config_validation(self, ignore_keys={"mrope_section"})
self.image_token_id = image_token_id
self.video_token_id = video_token_id

super().__init__(tie_word_embeddings=tie_word_embeddings, **kwargs)

Expand Down