-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Fix transformers MoE compatibility with VLLM #42429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3outeille
wants to merge
1
commit into
main
Choose a base branch
from
fix_moe_for_vllm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Script to test vLLM inference with transformers backend for MoE models | ||
| # Each model is tested and results are reported | ||
|
|
||
| # Define colors for output | ||
| GREEN='\033[0;32m' | ||
| RED='\033[0;31m' | ||
| YELLOW='\033[1;33m' | ||
| NC='\033[0m' # No Color | ||
|
|
||
| # Define models to test (architecture -> HuggingFace checkpoint) | ||
| declare -A MODELS=( | ||
| ["olmoe"]="allenai/OLMoE-1B-7B-0924" | ||
| ["mixtral"]="TitanML/tiny-mixtral" | ||
| ["qwen2_moe"]="Qwen/Qwen1.5-MoE-A2.7B-Chat" | ||
| ["qwen3_moe"]="tiny-random/qwen3-moe" | ||
| ["gpt_oss"]="tiny-random/gpt-oss" | ||
| ) | ||
|
|
||
| # Results tracking | ||
| declare -A RESULTS | ||
|
|
||
| echo "==========================================" | ||
| echo " MoE Models Inference Test Script" | ||
| echo "==========================================" | ||
| echo "" | ||
|
|
||
| # Function to run inference test | ||
| run_test() { | ||
| local model_name=$1 | ||
| local model_checkpoint=$2 | ||
|
|
||
| echo -e "${YELLOW}Testing: ${model_name} (${model_checkpoint})${NC}" | ||
| echo "-------------------------------------------" | ||
|
|
||
| # Set environment and run the command | ||
| VLLM_ENABLE_V1_MULTIPROCESSING=0 python vllm/examples/offline_inference/basic/generate.py \ | ||
| --model "$model_checkpoint" \ | ||
| --model-impl transformers \ | ||
| --enforce-eager \ | ||
| --no-enable-prefix-caching \ | ||
| 2>&1 | ||
|
|
||
| local exit_code=$? | ||
|
|
||
| if [ $exit_code -eq 0 ]; then | ||
| RESULTS[$model_name]="SUCCESS" | ||
| echo -e "${GREEN}✓ ${model_name}: SUCCESS${NC}" | ||
| else | ||
| RESULTS[$model_name]="FAILED (exit code: $exit_code)" | ||
| echo -e "${RED}✗ ${model_name}: FAILED (exit code: $exit_code)${NC}" | ||
| fi | ||
|
|
||
| echo "" | ||
| return $exit_code | ||
| } | ||
|
|
||
| # Run tests for each model | ||
| for model_name in "${!MODELS[@]}"; do | ||
| run_test "$model_name" "${MODELS[$model_name]}" | ||
| done | ||
|
|
||
| # Print summary | ||
| echo "" | ||
| echo "==========================================" | ||
| echo " SUMMARY" | ||
| echo "==========================================" | ||
| echo "" | ||
|
|
||
| success_count=0 | ||
| fail_count=0 | ||
|
|
||
| for model_name in "${!RESULTS[@]}"; do | ||
| result="${RESULTS[$model_name]}" | ||
| if [[ "$result" == "SUCCESS" ]]; then | ||
| echo -e "${GREEN}✓ ${model_name}: ${result}${NC}" | ||
| ((success_count++)) | ||
| else | ||
| echo -e "${RED}✗ ${model_name}: ${result}${NC}" | ||
| ((fail_count++)) | ||
| fi | ||
| done | ||
|
|
||
| echo "" | ||
| echo "-------------------------------------------" | ||
| echo -e "Total: ${GREEN}${success_count} passed${NC}, ${RED}${fail_count} failed${NC}" | ||
| echo "==========================================" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove when we merge!