Kernel mapping error resolve #42466
Open
Kernel mapping error resolve #42466
+67
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaraviitkgp
force-pushed
the
kernel_mapping_error_resolve
branch
from
9623bfe to
04e27cb
Compare
Aaraviitkgp
force-pushed
the
kernel_mapping_error_resolve
branch
from
5a4a08a to
e328d0c
Compare
Author
|
@Rocketknight1 I noticed that the run test issues that is occuring ColQwen2ForRetrieval: Tensor vlm.lm_head.weight seems to have nothing to do with the changes made in pr. |
4 tasks
Member
|
cc @MekkCyber for kernels I think! also @Aaraviitkgp that |
Author
|
@Rocketknight1 the test_processor and test_tokenization have similar issue they fail but no changes in pr related to them can you look into that aswell 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #42451
This PR fixes a bug in KernelConfig.create_compatible_mapping where defining a kernel mapping for multiple devices (e.g., both cuda and rocm) caused the last defined device to overwrite the active device configuration.
@Rocketknight1 @MekkCyber