Skip to content

Conversation

@Sai-Suraj-27
Copy link
Contributor

What does this PR do?

Fixes these failing tests in Glm4vMoeIntegrationTest.

image

As discussed here, It depends on how pytest collects the different tests, so similar to Lfm2MoeIntegrationTest, Qwen3MoeIntegrationTest (which are not failing in their get_model() function calls with this issue) it would be ideal to have setUpClass that initializes cls.model always.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh @Cyrilvallez

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: glm4v_moe

@ydshieh
Copy link
Collaborator

ydshieh commented Dec 1, 2025

Thank you @Sai-Suraj-27 I will take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants