Skip to content

Refactor treadmill controls#94

Open
HoLuLuLu wants to merge 4 commits intohughesjs:masterfrom
HoLuLuLu:Refactor-treadmill-controls
Open

Refactor treadmill controls#94
HoLuLuLu wants to merge 4 commits intohughesjs:masterfrom
HoLuLuLu:Refactor-treadmill-controls

Conversation

@HoLuLuLu
Copy link
Copy Markdown
Contributor

  • Use two buttons
    • left button for start/pause/resume
      • start button will switch to pause button if workout started by clicking on it
      • pause button will switch to resume button if workout paused by clicking on it
      • resume button will switch to pause button if workout resumed by clicking on it
    • right button for stop
      • button is deactivated until workout started
      • clicking on it will stop the workout and reset the button layouts
  • Use current workout state from WorkoutStateManager
  • Add timer to display countdown in app (will interrupt if pad starts earlier)
  • Add comments on some checks

FitnessMachine_pause
FitnessMachine_resume
FitnessMachine_start

- Use two buttons
- Use current workout state from workout_state_manager.dart for buttons
- Add timer to display countdown in app (will interrupt if pad starts earlier)
- Add some comments on some checks
- Fix _listen()
@HoLuLuLu
Copy link
Copy Markdown
Contributor Author

This should affect #54

@hughesjs
Copy link
Copy Markdown
Owner

Hi mate, I have been so busy this last few weeks, I've only just seen your PRs come in, sorry! I'll try and get them all reviewed this weekend. Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants