Fix duplicate load_inference_datasets definition and improve dataset loading utilities#6
Open
swagat-mishra28 wants to merge 2 commits intohumanai-foundation:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
While reviewing the dataset loading utilities, I noticed that the function
load_inference_datasetsappears twice in the same file. The second definition partially overrides the earlier one and may lead to unexpected behavior.This PR removes the duplicate function definition and keeps the complete implementation.
I also removed the tqdm progress bar inside the dataset loading loop. Running progress bars inside dataset iteration can introduce unnecessary overhead during training, especially when the dataset is accessed frequently by the DataLoader.
Additionally, a few small adjustments were made to related utilities to keep the dataset loading logic consistent.
Overall, these changes aim to make the dataset loader cleaner, slightly more efficient, and easier to maintain.