Fix: Resolve dictionary key overwrites and missing pandas import in data generation pipeline#92
Open
kamilansri wants to merge 1 commit intohumanai-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several critical bugs in the
data_generation_pipelinescript that prevented successful execution and caused silent logic failures.Changes Made
import pandas as pdat the top of the file to prevent aNameErrorduring the final dataset CSV read.book_transformationsdictionary. Previously, consecutive identical keys (e.g.,'denoise_image') were overwriting each other natively in Python. These sequential steps have been bundled into lists (e.g.,'denoise_image': [{'method': 'bilateral'}, {'method': 'nlm'}]) to preserve the pipeline's operational intent. (Note: Ensureprocess_multiple_booksis equipped to parse these list values).dffrom being assigned and overwritten three separate times in sequence. Variables are now explicitly named (regions_df,dataset_df,final_df) to improve debugging capability.0.8inmapping_bounding_boxeswith the initializedsimilarity_thresholdvariable.