Fix: robustify file handling and resolve path creation bugs in utils#96
Open
kamilansri wants to merge 1 commit intohumanai-foundation:mainfrom
Open
Fix: robustify file handling and resolve path creation bugs in utils#96kamilansri wants to merge 1 commit intohumanai-foundation:mainfrom
kamilansri wants to merge 1 commit intohumanai-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several bugs and cleans up the utility functions handling file discovery and result saving for the text detection outputs.
Changes Made
.tiffcheck inlist_files(previously'tiff'), ensuring TIFF files are correctly identified.if ext == ... or ext == ...chains into O(1) set lookups (in {'.jpg', '.png', ...}).dirname + "res_" + filename + '.txt') to useos.path.jointo prevent path malformations ifdirnameis passed without a trailing slash.os.mkdirwithos.makedirs(dirname, exist_ok=True). The previous implementation would crash if the parent directory didn't exist or if a race condition occurred in a multi-threaded environment.Checklist