Skip to content

Keycloak error page#57

Open
yonas-seyoum wants to merge 3 commits intodevelopmentfrom
Keycloak-Error-page
Open

Keycloak error page#57
yonas-seyoum wants to merge 3 commits intodevelopmentfrom
Keycloak-Error-page

Conversation

@yonas-seyoum
Copy link
Copy Markdown
Contributor

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@peterrogov peterrogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. But this is too narrow.

  1. We only use the previous problem with keycloak as an example. The code we make here must handle any (!) error that might occur in the app and go unhandled. Any unhandled exception anywhere.

  2. You might really want to consider using ErrorBoundary for this. Read about it.

  3. An error occurred during keycloak initialization is a bad idea. Do not allow your user-facing error message to leak any significant implementation details about the app. This violates security very much. You want your logs, that are only visible to admins, to have every neccessary details. But user facing messages must be user facing. In this case just "Service temporary unavailable" or at most "Due to a technical problem we cannot authenticate you right now". That's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants