Skip to content

[Bug fix] Change Password Button #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yonas-seyoum wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[Bug fix] Change Password Button #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c15efa
Change react-router-dom Link to mui Link
yonas-seyoum Nov 12, 2023
fe0af44
remove code smell
yonas-seyoum Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions applications/webapp/src/Pages/User/components/detailHolder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ import {
TextField,
Button,
Box,
Link,
} from "@mui/material";
import { styles } from "../util/style";
import { useMutation } from "@apollo/client";
import { EditUserMutation } from "../../../hooks/mutation";
import { useCardContext, useUserContext } from "../context";
import { Link } from "react-router-dom";
import { CHANGE_PASSWORD_URL } from "../util/constants";

export default function DetailHolder() {
Expand All @@ -44,7 +44,7 @@ export default function DetailHolder() {

const [editUser] = useMutation(EditUserMutation);

async function updateUser() {
const updateUser = React.useCallback(async () => {
try {
const { data } = await editUser({
variables: {
Expand All @@ -58,19 +58,21 @@ export default function DetailHolder() {
}
setEditable(!editable);
setElevation(0);
}
}, [firstname, lastname, editUser, setEditable, setElevation]);

function firstNameChanged(
event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>,
) {
return setFirstname(event.target.value);
}
const firstNameChanged = React.useCallback(
(event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
return setFirstname(event.target.value);
},
[setFirstname],
);

function lastNameChanged(
event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>,
) {
return setLastname(event.target.value);
}
const lastNameChanged = React.useCallback(
(event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
return setLastname(event.target.value);
},
[setLastname],
);

return (
<Card elevation={card.elevation} sx={style.card}>
Expand Down Expand Up @@ -140,7 +142,7 @@ export default function DetailHolder() {
<Button variant="contained" onClick={updateUser}>
Update
</Button>
<Link to={CHANGE_PASSWORD_URL}>
<Link href={CHANGE_PASSWORD_URL}>
<Button variant="contained" color="warning">
Change Password
</Button>
Expand Down