Open
Conversation
Member
Author
|
Remaining lint error is due to a PHP incompatibility, and is not part of this PR. |
joehoyle
reviewed
Sep 15, 2025
|
|
||
| break; | ||
| // Check certificate expiration. | ||
| $validity_remaining = $this->check_ssl_expiry( $cert_file ); |
Member
There was a problem hiding this comment.
Hmm are we catching this error? Do we want to block being able to start the server if the openssl call fails? IMO best to just show a warning "Could not get certificate expiry details" but still start the server?
mikelittle
requested changes
Sep 15, 2025
| case '': | ||
| $cert_exists = file_exists( 'vendor/ssl-cert.pem' ) && file_exists( 'vendor/ssl-key.pem' ); | ||
| $cert_file = 'vendor/ssl-cert.pem'; | ||
| $cert_exists = file_exists( $cert_file ) && file_exists( $cert_file ); |
Contributor
There was a problem hiding this comment.
Should this second test be for the key file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically regenerates certificates on
composer server startif they're expiring soon:Also changes
composer server sslto output remaining validity days:And error if it's expired.
Fixes #849.