-
Notifications
You must be signed in to change notification settings - Fork 9
Fix pagination issue with migrate wp authors CLI command. #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattheu
wants to merge
6
commits into
develop
Choose a base branch
from
fix-migrate-authors-query-pagination
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dc23c86
Fix migrate authors query pagination
mattheu baedf57
Update comment
mattheu 8faa8f6
Merge remote-tracking branch 'origin/main' into fix-migrate-authors-q…
mattheu 51504c2
Add unit test for pagination when overwriting
mattheu f4fd257
Fix correct post ID vs post object
mattheu 3f768a6
Set default value
mattheu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| <?php | ||
| /** | ||
| * Plugin CLI command tests. | ||
| * | ||
| * @package authorship | ||
| */ | ||
|
|
||
| declare( strict_types=1 ); | ||
|
|
||
| namespace Authorship\Tests; | ||
|
|
||
| use Authorship\CLI; | ||
| use const Authorship\POSTS_PARAM; | ||
| use const Authorship\TAXONOMY; | ||
|
|
||
| class TestCLI extends TestCase { | ||
| public function set_up() { | ||
| parent::set_up(); | ||
| require_once dirname( __DIR__, 2 ) . '/inc/cli/namespace.php'; | ||
| require_once dirname( __DIR__, 2 ) . '/inc/cli/class-migrate-command.php'; | ||
| CLI\bootstrap(); | ||
| } | ||
|
|
||
| public function testMigrateWpAuthorsPagination() : void { | ||
| $factory = self::factory()->post; | ||
| $posts = []; | ||
|
|
||
| for ( $i = 0; $i < 200; $i++ ) { | ||
| $posts[] = $factory->create_and_get( [ | ||
| 'post_author' => self::$users['admin']->ID, | ||
| POSTS_PARAM => [ | ||
| self::$users['editor']->ID, | ||
| ], | ||
| ] ); | ||
| } | ||
|
|
||
| $paged_post = $posts[100]; // Any post from second page of results. | ||
| $authorship_authors = \Authorship\get_authors( $paged_post ); | ||
|
|
||
| // Asset initial authorship authors set correctly. | ||
| $this->assertCount( 1, $authorship_authors ); | ||
| $this->assertSame( self::$users['editor']->ID, $authorship_authors[0]->ID ); | ||
|
|
||
| // Migrate, overwriting authorship data with WP Author data. | ||
| $command = new CLI\Migrate_Command; | ||
| $command->wp_authors( [], [ | ||
| 'dry-run' => false, | ||
| 'overwrite' => true, | ||
| 'post-type' => 'post', // Must set default value manually. | ||
| ] ); | ||
|
|
||
| // Verify author data migrated correctly. | ||
| $authorship_authors = \Authorship\get_authors( $paged_post->ID ); | ||
| $this->assertCount( 1, $authorship_authors ); | ||
| $this->assertSame( self::$users['admin']->ID, $authorship_authors[0]->ID ); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.